docs(README): external install tip improvements #1415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scop
commented
Aug 10, 2025
Comment on lines
-210
to
+215
| include(GNUInstallDirs) | ||
| find_package(bash-completion) | ||
| if(BASH_COMPLETION_FOUND) | ||
| message(STATUS | ||
| "Using bash completion dir ${BASH_COMPLETION_COMPLETIONSDIR}") | ||
| else() | ||
| include(GNUInstallDirs) |
There was a problem hiding this comment.
This is fairly cosmetic I suppose and I don't know if it actually works, but would make sense to me. It's a separate commit we can remove if it doesn't.
There was a problem hiding this comment.
I don't use cmake, so I'm not familiar with it. AI says it works, and AI is probably right, but I'm not sure whether there is anything that we should be careful with. I think the original author @jtojnar should know this better.
There was a problem hiding this comment.
I believe conditional imports are fine in CMake should probably work. Though, in practice, it should be used elsewhere in the CMake script too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion in #1379 (comment) and onwards.